[8.x](backport #41626) Support location_label config in GCP Metrics Metricset
#41852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Support of servicelabel config * Update the label * update location_label * Add metricbeat and gcp.yml.disabled * Update changelog * update gcp asciidoc * adress review comments (cherry picked from commit 3144d38)
mergify
bot
requested review from
AndersonQ and
VihasMakwana
and removed request for
a team
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Explain here the changes you made on the PR.
Please explain:
location_labelconfig option to get the resource label for the new GCP service from the usermetrics metricsetwas used for a new GCP service, the resource label used for data filtering was always the default "resource.label.zone", which may/may not be correct depending on the service. This PR get this label through config from the user.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Screenshots
This is an automatic backport of pull request #41626 done by [Mergify](https://mergify.com).